Maor Lipchuk has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 7: Code-Review+1 (6 comments) See minor comments inline http://gerrit.ovirt.org/#/c/22951/7/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1105: POWER_MANAGEMENT_ACTION_ON_ENTITY_ALREADY_IN_PROGRESS=Cannot perform ${action}. Another power management action is already in progress. Line 1106: LABELED_NETWORK_INTERFACE_NOT_FOUND=A labeled network interface could not be found. Line 1107: NETWORK_LABEL_CONFLICT=The networks represented by label cannot be configured on the same network interface. Line 1108: Line 1109: VALIDATION.ISCSI_BOND.NAME.MAX=Iscsi bond name must not exceed 50 characters /s/Iscsi/iSCSI Line 1110: VALIDATION.ISCSI_BOND.NAME.NOT_NULL=Iscsi bond name is required Line 1111: VALIDATION.ISCSI_BOND.DESCRIPTION.MAX=Iscsi bond description must not exceed 4000 characters Line 1112: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be formed from alpha-numeric characters or "-_." Line 1106: LABELED_NETWORK_INTERFACE_NOT_FOUND=A labeled network interface could not be found. Line 1107: NETWORK_LABEL_CONFLICT=The networks represented by label cannot be configured on the same network interface. Line 1108: Line 1109: VALIDATION.ISCSI_BOND.NAME.MAX=Iscsi bond name must not exceed 50 characters Line 1110: VALIDATION.ISCSI_BOND.NAME.NOT_NULL=Iscsi bond name is required same Line 1111: VALIDATION.ISCSI_BOND.DESCRIPTION.MAX=Iscsi bond description must not exceed 4000 characters Line 1112: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be formed from alpha-numeric characters or "-_." Line 1107: NETWORK_LABEL_CONFLICT=The networks represented by label cannot be configured on the same network interface. Line 1108: Line 1109: VALIDATION.ISCSI_BOND.NAME.MAX=Iscsi bond name must not exceed 50 characters Line 1110: VALIDATION.ISCSI_BOND.NAME.NOT_NULL=Iscsi bond name is required Line 1111: VALIDATION.ISCSI_BOND.DESCRIPTION.MAX=Iscsi bond description must not exceed 4000 characters same Line 1112: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be formed from alpha-numeric characters or "-_." Line 1108: Line 1109: VALIDATION.ISCSI_BOND.NAME.MAX=Iscsi bond name must not exceed 50 characters Line 1110: VALIDATION.ISCSI_BOND.NAME.NOT_NULL=Iscsi bond name is required Line 1111: VALIDATION.ISCSI_BOND.DESCRIPTION.MAX=Iscsi bond description must not exceed 4000 characters Line 1112: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be formed from alpha-numeric characters or "-_." same Line 1109: VALIDATION.ISCSI_BOND.NAME.MAX=Iscsi bond name must not exceed 50 characters Line 1110: VALIDATION.ISCSI_BOND.NAME.NOT_NULL=Iscsi bond name is required Line 1111: VALIDATION.ISCSI_BOND.DESCRIPTION.MAX=Iscsi bond description must not exceed 4000 characters Line 1112: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be formed from alpha-numeric characters or "-_." Line 1113: VALIDATION.ISCSI_BOND.DESCRIPTION.INVALID=Iscsi Bond description must be formed only from alpha-numeric characters and special characters that conform to the standard ASCII character set. same http://gerrit.ovirt.org/#/c/22951/7/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java: Line 28: dao = dbFacade.getIscsiBondDao(); Line 29: storagePoolId = new Guid("6d849ebf-755f-4552-ad09-9a090cda105d"); Line 30: iscsiBondId = new Guid("7368f2be-1263-41f8-b95e-70cdaf23b80d"); Line 31: networkId = new Guid("58d5c1c6-cb15-4832-b2a4-023770607190"); Line 32: connectionId = "0cc146e8-e5ed-482c-8814-270bc48c297e"; Please see my last comment. You can replace the declaration of storagePoolId with FixturesTool.STORAGE_POOL_RHEL6_ISCSI_OTHER also network id with FixturesTool.NETWORK_NO_CLUSTERS_ATTACHED I would wormly suggest to add the connectionId and the IscsiBondId there, it will make the test look much more readable Line 33: Line 34: newIscsiBond = new IscsiBond(); Line 35: newIscsiBond.setId(Guid.newGuid()); Line 36: newIscsiBond.setName("Multipath"); -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
