Maor Lipchuk has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/22951/6/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1106: LABELED_NETWORK_INTERFACE_NOT_FOUND=A labeled network interface could not be found. Line 1107: NETWORK_LABEL_CONFLICT=The networks represented by label cannot be configured on the same network interface. Line 1108: Line 1109: VALIDATION.ISCSI_BOND.NAME.INVALID.CHARACTER=Iscsi Bond name must be formed from alpha-numeric characters or "-_." Line 1110: VALIDATION.ISCSI_BOND.NAME.INVALID.LENGTH=Length of {0} has to be between {1} and {2} where those parameters are being initiailzed? http://gerrit.ovirt.org/#/c/22951/6/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/IscsiBondDaoTest.java: Line 28: dao = dbFacade.getIscsiBondDao(); Line 29: storagePoolId = new Guid("6d849ebf-755f-4552-ad09-9a090cda105d"); Line 30: iscsiBondId = new Guid("7368f2be-1263-41f8-b95e-70cdaf23b80d"); Line 31: networkId = new Guid("58d5c1c6-cb15-4832-b2a4-023770607190"); Line 32: connectionId = "0cc146e8-e5ed-482c-8814-270bc48c297e"; Please use FixturesTool for this Guids Line 33: Line 34: newIscsiBond = new IscsiBond(); Line 35: newIscsiBond.setId(Guid.newGuid()); Line 36: newIscsiBond.setName("Multipath"); Line 77: newIscsiBond.setDescription("10GB iscsi bond"); Line 78: dao.update(newIscsiBond); Line 79: Line 80: IscsiBond iscsiBond = dao.get(newIscsiBond.getId()); Line 81: assertEquals(newIscsiBond, iscsiBond); The equals here doesnt' check anything. You should check if the description has been changed Line 82: } Line 83: Line 84: @Test Line 85: public void testRemoveIscsiBond() { Line 81: assertEquals(newIscsiBond, iscsiBond); Line 82: } Line 83: Line 84: @Test Line 85: public void testRemoveIscsiBond() { I would first use dao.get and check that it returns full Line 86: dao.remove(iscsiBondId); Line 87: Line 88: IscsiBond iscsiBond = dao.get(iscsiBondId); Line 89: List<Guid> networks = dao.getNetworkIdsByIscsiBondId(iscsiBondId); -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
