Eli Mesika has posted comments on this change. Change subject: engine, dao: Introduce ISCSI Bond entity, tables and dao ......................................................................
Patch Set 4: (4 comments) .................................................... File packaging/dbscripts/upgrade/03_04_0390_add_iscsi_bond.sql Line 7: CONSTRAINT PK_iscsi_bonds PRIMARY KEY(id) Line 8: ) WITH OIDS; Line 9: Line 10: ALTER TABLE iscsi_bonds ADD CONSTRAINT FK_iscsi_bonds_storage_pool FOREIGN KEY(storage_pool_id) Line 11: REFERENCES storage_pool(id) ON DELETE CASCADE; Since you are creating the table , you can create also the FK as you are doing for the PK in the Create statement , see http://www.postgresql.org/docs/8.1/static/sql-createtable.html Line 12: Line 13: CREATE TABLE iscsi_bonds_networks_map Line 14: ( Line 15: iscsi_bond_id UUID NOT NULL, Line 20: ALTER TABLE iscsi_bonds_networks_map ADD CONSTRAINT FK_iscsi_bonds_networks_map_iscsi_bond_id FOREIGN KEY(iscsi_bond_id) Line 21: REFERENCES iscsi_bonds(id) ON DELETE CASCADE; Line 22: Line 23: ALTER TABLE iscsi_bonds_networks_map ADD CONSTRAINT FK_iscsi_bonds_networks_map_network_id FOREIGN KEY(network_id) Line 24: REFERENCES network(id) ON DELETE CASCADE; same Line 25: Line 26: CREATE TABLE iscsi_bonds_storage_connections_map Line 27: ( Line 28: iscsi_bond_id UUID NOT NULL, Line 30: CONSTRAINT PK_iscsi_bonds_storage_connections_map PRIMARY KEY(iscsi_bond_id,connection_id) Line 31: ) WITH OIDS; Line 32: Line 33: ALTER TABLE iscsi_bonds_storage_connections_map ADD CONSTRAINT FK_iscsi_bonds_storage_connections_map_iscsi_bond_id FOREIGN KEY(iscsi_bond_id) Line 34: REFERENCES iscsi_bonds(id) ON DELETE CASCADE; same Line 35: Line 36: ALTER TABLE iscsi_bonds_storage_connections_map ADD CONSTRAINT FK_iscsi_bonds_storage_connections_map_connection_id FOREIGN KEY(connection_id) Line 33: ALTER TABLE iscsi_bonds_storage_connections_map ADD CONSTRAINT FK_iscsi_bonds_storage_connections_map_iscsi_bond_id FOREIGN KEY(iscsi_bond_id) Line 34: REFERENCES iscsi_bonds(id) ON DELETE CASCADE; Line 35: Line 36: ALTER TABLE iscsi_bonds_storage_connections_map ADD CONSTRAINT FK_iscsi_bonds_storage_connections_map_connection_id FOREIGN KEY(connection_id) Line 37: REFERENCES storage_server_connections(id) ON DELETE CASCADE; same -- To view, visit http://gerrit.ovirt.org/22951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12313c02810a2f0e75016bdd78b44da43f2154d4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches