Gilad Chaplik has posted comments on this change.
Change subject: webadmin: adding externalize check to the frontend checkstyle
......................................................................
Patch Set 13: (5 inline comments)
....................................................
File build-tools/checks/src/main/java/NlsCheck.java
Line 39: if (lineText.matches("^\\s*@.*")) {
http://en.wikipedia.org/wiki/Polish_notation
Line 98:
+1
....................................................
File frontend/webadmin/modules/gwt-common/pom.xml
Line 146: </build>
what is the change??? avoid formatting the code.
....................................................
File frontend/webadmin/modules/uicommonweb/pom.xml
Line 57: </build>
same
....................................................
File frontend/webadmin/modules/webadmin/pom.xml
Line 346: </profiles>
same
--
To view, visit http://gerrit.ovirt.org/3760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie23035701398158b70b61c1c85a7f6eb40770784
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
