Doron Fediuck has posted comments on this change. Change subject: webadmin: adding externalize check to the frontend checkstyle ......................................................................
Patch Set 13: (4 inline comments) .................................................... File build-tools/checks/pom.xml Line 9: <artifactId>checks</artifactId> ovirt-checkstyle-extensions could be more clear for outsiders. .................................................... File build-tools/pom.xml Line 9: <artifactId>build-tools</artifactId> should be build-tools-parent or build-tools-root. Line 11: <name>oVirt Build Tools</name> should be build-tools-parent or build-tools-root. .................................................... File pom.xml Line 368: <version>3.1.0-0001</version> Try using engine.version -- To view, visit http://gerrit.ovirt.org/3760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23035701398158b70b61c1c85a7f6eb40770784 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
