Alona Kaplan has posted comments on this change. Change subject: webadmin: adding externalize check to the frontend checkstyle ......................................................................
Patch Set 10: Gilad,as I wrote in http://gerrit.ovirt.org/#change,3612 - patch set 9 Regarding Eclipse/mvn plug-in There is a build in option in eclipse to mark (throw compile error) non-externalized strings. preferences=>java=>compiler=>errors/warning=>non-externalized strings (missing/unused $NON-NLS$ tag) => error There is also another option- you can add to the eclipse a checkstyle-plugin (help=>marketplace=>checkstyle) and make our checkstyle.xml file to be the default eclipse checkstyle (like explained here- http://eclipse-cs.sourceforge.net/basic_setup_project.html). I will cause all checksyle errors to be marked in the eclipse configuration. -- To view, visit http://gerrit.ovirt.org/3760 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie23035701398158b70b61c1c85a7f6eb40770784 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
