Sharad Mishra has uploaded a new change for review. Change subject: engine: Allow to iterate over remaining ldap servers on NullPointerException. ......................................................................
engine: Allow to iterate over remaining ldap servers on NullPointerException. When engine-manage-domain is run to add ldap server, current code finds all ldap servers in the domain and then finds guid on each. In some cases it gets NullPointerException because the "uniqueId" is not found. In those cases we currently go to the default "Exception" and break out of ldap server loop. In my view, we should log/print the message and continue to serve the loop. This is the second version of the patch. I am new to gerrit, tried using 'fixup' to preserve original change-id but did not work. This patch has updates based on review comments. The original patch is at http://gerrit.ovirt.org/#change,3935. Change-Id: Ic1088dc1a5852759375422e5e97556ee01b16c56 Signed-off-by: Sharad Mishra <snmis...@linux.vnet.ibm.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 19 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/4439/1 -- To view, visit http://gerrit.ovirt.org/4439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic1088dc1a5852759375422e5e97556ee01b16c56 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
