Sharad Mishra has posted comments on this change. Change subject: engine: Allow to iterate over remaining ldap servers on NullPointerException. ......................................................................
Patch Set 1: I am open to the idea of doing something in guidFromResults(), but throwing NamingException will not solve this issue. If we throw a subclass of NamingException, then we need to add code to run() to handle it. And it can be misleading too. -- To view, visit http://gerrit.ovirt.org/3935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b07cfaa2753bdbcf760245997efee8611e596b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
