Ryan Harper has posted comments on this change. Change subject: engine: Allow to iterate over remaining ldap servers on NullPointerException. ......................................................................
Patch Set 1: I agree with the logging. Not having spent a lot of time in the engine code, not sure if we should just catch NULL in the outer loop or do something closer in, like how about testing for NULL in guidFromResults() and throwing the NamingException; then catch that in the while loop? -- To view, visit http://gerrit.ovirt.org/3935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b07cfaa2753bdbcf760245997efee8611e596b4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
