Juan Hernandez has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 5: Maven dependencies or Fedora package dependencies are designed for general purpose usage, and in general they aren't what is needed in runtime, not even a superset. The purpose of the JBoss modules that we include in oVirt engine is to allow loading of the classes that oVirt engine needs, and oVirt engine doesn't need the classes added in this change. Of course not all of us have the expertise to decide what is required or not (although it is pretty simple, and obvious in this particular case). But this isn't a valid rule, if we were to use it then we won't be doing anything as nobody in the team knows everything. What is relevant is that as a team we do have the required expertise and we have already used it to prune these useless dependencies. -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
