Juan Hernandez has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 5: The chain of dependencies that this is trying to fix isn't impossible, it is just that the problem doesn't exist. The oVirt engine doesn't need any of the three dependencies added here, we are mistakenly assuming that maven dependencies are run time dependencies. The JBoss modules included in the oVirt engine should reflect the run time needs of oVirt engine, nothing else. Adding unneeded run time dependencies doesn't make us compatible with anything, as there are no rules or guidelines saying what JBoss modules in one product should include. For the oVirt engine we set those rules, and from my point of view one of the rules should be "if you don't need it you don't add it". -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
