Juan Hernandez has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 5: It is my understanding that rhevm-dependencies should contain what RHEV-M needs, nothing else. If RHEV-M doesn't need xz-java (for example) then I don't see the problem in not including it or the benefit of including it: it is just useless. I won't object if we want to blindly apply guidelines in the RPM packaging area, but RPM packaging guidelines aren't excuse to pollute the run time space of the application, which is what JBoss modules is about. -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
