Martin Peřina has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 5: Juan, you are right, that we currently don't load classes from those jars at runtime. But when oVirt is installed on F19, our rpm depends on apache-commons-compress which depends on xz-java. So to be 100% correct on RHEL 6, when we include apache-commons-compress in rhevm-dependencies rpm, we should also include xz to be as much compatible as possible. Similar scenarios for other two jars included in this patch. -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches