Alona Kaplan has uploaded a new change for review.

Change subject: webadmin: adding externalize check to the frontend checkstyle
......................................................................

webadmin: adding externalize check to the frontend checkstyle

no bz

see http://gerrit.ovirt.org/#change,3612
Changing the fronend project checkstyle plugin to checkstyle_frontend.xml
Adding to the pluging a new check- non externalized string.
This check fails if there is a non externalized string in a java file and
there is no //$NON-NLS-N$ comment to mark that it is ok that the string
is not externalized.

Change-Id: Ie23035701398158b70b61c1c85a7f6eb40770784
---
A build-tools/src/main/resources/checkstyle_frontend.xml
A checkstyle-checks/packagenames.xml
A checkstyle-checks/pom.xml
A checkstyle-checks/src/main/java/checks/NlsCheck.java
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M pom.xml
9 files changed, 226 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/3760/1
--
To view, visit http://gerrit.ovirt.org/3760
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie23035701398158b70b61c1c85a7f6eb40770784
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to