Ori Liel has posted comments on this change. Change subject: restapi: Migrates the brick data and mark it for deletion ......................................................................
Patch Set 8: (1 comment) .................................................... Commit Message Line 12: Line 13: Its different from the normal brick deletion in the sense that normal Line 14: delete works as force delete and removes the bricks from the volume Line 15: without any data migration. Whereas this option would migrate the data Line 16: first and then by using the commit deletes the brick from volume. I read your comments, but I still don't understand why it must be modelled with commit, and not like Michael suggested. Let me break it down to flows: * User wants to migrate a brick: POST .../api/clusters/xxx/glustervolumes/yyy/glusterbricks/zzz/migrate [migrates the data available on the said brick to rest of the bricks in the volume] * At some point later on, user decides to retain the brick for future use: - do nothing! OR * At some point later on, user decides that he does not need the brick anymore and wants to delete it permanently: DELETE .../api/clusters/xxx/glustervolumes/yyy/glusterbricks/zzz [deletes the brick] OR * At some point later on, user wants to stop an on-going migration of a brick data: POST .../api/clusters/xxx/glustervolumes/yyy/glusterbricks/zzz/stopmigrate [stops on-going migration of a brick data] This way we don't have intermediate states, everything is atomic actions. Line 17: Line 18: Usage: Line 19: - api/clusters/<cluster-Id>/glustervolumes/<volume-id>/bricks/migrate Line 20: -- To view, visit http://gerrit.ovirt.org/19400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa88f3402a25316d1717ee914aa77856fbe802db Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
