Michael Pasternak has posted comments on this change. Change subject: restapi: Migrates the brick data and mark it for deletion ......................................................................
Patch Set 8: Code-Review-2 (1 comment) .................................................... Commit Message Line 12: Line 13: Its different from the normal brick deletion in the sense that normal Line 14: delete works as force delete and removes the bricks from the volume Line 15: without any data migration. Whereas this option would migrate the data Line 16: first and then by using the commit deletes the brick from volume. this behaviour is not RESTfull, it should work like this: 1. DELETE on bricks (possibly with 'force' flag, see removing DC fro details) 2. action 'migrate' on /bricks, the meaning of migrate is the same as 'move', but if you would like to delete bricks manually, you may specify parameter in action.delete_when_completed = False and the invoke DELETE manually on each brick, also i'm not understand why 'commit' not automatically triggered in the engine command when 'migrate' is completed, that's the way we move disks from one SD to another. anyway you can't split operation in two steps in REST, as all operations should be stateless and modify resource state in general. Line 17: Line 18: Usage: Line 19: - api/clusters/<cluster-Id>/glustervolumes/<volume-id>/bricks/migrate Line 20: -- To view, visit http://gerrit.ovirt.org/19400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa88f3402a25316d1717ee914aa77856fbe802db Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
