Ori Liel has posted comments on this change. Change subject: restapi: Migrates the brick data and mark it for deletion ......................................................................
Patch Set 8: (1 comment) .................................................... Commit Message Line 12: Line 13: Its different from the normal brick deletion in the sense that normal Line 14: delete works as force delete and removes the bricks from the volume Line 15: without any data migration. Whereas this option would migrate the data Line 16: first and then by using the commit deletes the brick from volume. Sahina - is migration of a brick something that has a beginning and and end? Or is it more like turning the tap on, and letting water flow indefinitley? If it's something that has a beginning and and end, why not have 'commit' happen automatically, implicitly, when migration is done? User can still stop the migration, before it is 'done'. If migration is more like turning the tap on and letting water run, could you please explain to me in some more detail what happens there? Maybe we have trouble agreeing because I don't fully understand this aspect of your business. In general, we aspire to have an API with meaningful, atomic operations, and, as far as possible, no 'intermediate states' - meaning, nothing that could be considered an on-going 'conversation' between the client and the server (that's considered: 'un-REST-ful'). Line 17: Line 18: Usage: Line 19: - api/clusters/<cluster-Id>/glustervolumes/<volume-id>/bricks/migrate Line 20: -- To view, visit http://gerrit.ovirt.org/19400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa88f3402a25316d1717ee914aa77856fbe802db Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
