Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: add constants list to the engine
......................................................................


Patch Set 3:

(2 comments)

....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 665:     ORIGINAL_GENERATED_BY_VERSION = 
'OVESETUP_CORE/originalGeneratedByVersion'
Line 666: 
Line 667:     LEGACY_PG_CREDS_FOUND = 'OVESETUP_CORE/legacyPGCredsFound'
Line 668: 
Line 669:     SETUP_ATTRS_MODULES = 'OVESETUP_CORE/attributesModules'
setupAttributesModules
Line 670: 
Line 671: 
Line 672: @util.export
Line 673: @util.codegen


....................................................
File packaging/setup/plugins/ovirt-engine-common/core/misc.py
Line 100: 
Line 101:         self.environment.setdefault(
Line 102:             osetupcons.CoreEnv.SETUP_ATTRS_MODULES,
Line 103:             [osetupcons]
Line 104:         )
no set default as we do not want anything externally damage our execution path, 
just set.
Line 105: 
Line 106:         if self.environment[osetupcons.CoreEnv.DEVELOPER_MODE] is 
None:
Line 107:             self.environment[osetupcons.CoreEnv.DEVELOPER_MODE] = 
False
Line 108:             if os.geteuid() != 0:


-- 
To view, visit http://gerrit.ovirt.org/20336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c919ed564003ed93300a84fc9072443eb865cf0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to