Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: add constants list to the engine ......................................................................
Patch Set 2: (2 comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 665: ORIGINAL_GENERATED_BY_VERSION = 'OVESETUP_CORE/originalGeneratedByVersion' Line 666: Line 667: LEGACY_PG_CREDS_FOUND = 'OVESETUP_CORE/legacyPGCredsFound' Line 668: Line 669: def CONSTANTS(self): SETUP_ATTRS_MODULES? Line 670: return 'OVESETUP_CORE/constants' Line 671: Line 672: Line 673: @util.export .................................................... File packaging/setup/plugins/ovirt-engine-common/system/environment.py Line 85: self.environment( Line 86: osetupcons.CoreEnv.CONSTANTS, Line 87: [osetupcons] Line 88: ) Line 89: should not be part of system, should be part of core. and this statement is wrong as far as I know. Line 90: -- To view, visit http://gerrit.ovirt.org/20336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c919ed564003ed93300a84fc9072443eb865cf0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
