Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: add constants list to the engine ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 757: Line 758: Line 759: @util.export Line 760: @util.codegen Line 761: class System(object): I do not like the name "System", as from a glance I can't see the difference between its meaning and 'SystemEnv' below, but I agree that they serve different needs and do not have a better name. Line 762: CONSTANTS = [] Line 763: Line 764: Line 765: @util.export -- To view, visit http://gerrit.ovirt.org/20336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c919ed564003ed93300a84fc9072443eb865cf0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
