Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: add constants list to the engine ......................................................................
Patch Set 1: (3 comments) .................................................... File packaging/setup/ovirt_engine_setup/constants.py Line 663 Line 664 Line 665 Line 666 Line 667 Add here environment that contains the modules to be loaded. Default is the constants.py... other modules can add them-selves. Line 758: Line 759: @util.export Line 760: @util.codegen Line 761: class System(object): Line 762: CONSTANTS = [] please use environment for all. Line 763: Line 764: Line 765: @util.export Line 766: @util.codegen .................................................... File packaging/setup/plugins/ovirt-engine-common/system/environment.py Line 81: osetupcons.SystemEnv.USER_POSTGRES, Line 82: osetupcons.Defaults.DEFAULT_SYSTEM_USER_POSTGRES Line 83: ) Line 84: Line 85: osetupcons.System.CONSTANTS.append(osetupcons) it should be in core not system... Line 86: Line 87: -- To view, visit http://gerrit.ovirt.org/20336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c919ed564003ed93300a84fc9072443eb865cf0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
