Martin Sivák has posted comments on this change.
Change subject: core: adding HA score with proper scheduling policies
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HAClusterFilterPolicyUnit.java
Line 33: log.debugFormat("Host {0} was filtered out as it
doesn't have a positive score", host.getName());
Line 34: }
Line 35: }
Line 36:
Line 37: if (filteredOutHosts) {
The truth is it does not really matter, we do not show any error message if
there was an available host. But you can still use hosts.size() !=
hostsToRunOn.size() here instead of the boolean.
Ideally (and that would require a change that is out of scope of this patch) we
would use Set and comparing two sets is easy and cheap.
Line 38:
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_NO_HA_VDS.toString());
Line 39: }
Line 40:
Line 41: return hostsToRunOn;
--
To view, visit http://gerrit.ovirt.org/20018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24879ed64cab829969556fd71786b32d3aaaf0c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
