Oved Ourfali has posted comments on this change.
Change subject: core: adding HA score with proper scheduling policies
......................................................................
Patch Set 2:
(2 comments)
See me two comments.
Also, I'll document the score, and change the name of the filter and weight
classes.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/HAClusterFilterPolicyUnit.java
Line 33: log.debugFormat("Host {0} was filtered out as it
doesn't have a positive score", host.getName());
Line 34: }
Line 35: }
Line 36:
Line 37: if (filteredOutHosts) {
I thought the purpose here was to give a message in case *any* host was
filtered out.
If the case is that it is only if *all* hosts were filtered out then you're
right. My bad.
Line 38:
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_NO_HA_VDS.toString());
Line 39: }
Line 40:
Line 41: return hostsToRunOn;
....................................................
File packaging/dbscripts/upgrade/03_03_0990_add_ha_policy_units.sql
Line 1:
Line 2: INSERT INTO policy_units (id, name, is_internal,
custom_properties_regex, type, enabled, description) VALUES
('e659c871-0bf1-4ccc-b748-f28f5d08dffd', 'HA', true, NULL, 0, true, 'Runs the
hosted engine VM only on hosts with a positive score');
Line 3: INSERT INTO policy_units (id, name, is_internal,
custom_properties_regex, type, enabled, description) VALUES
('98e92667-6161-41fb-b3fa-34f820ccbc4b', 'HA', true, NULL, 1, true, 'Weights
hosts according to there HA score');
nice catch :-)
Line 4:
Line 5: INSERT INTO cluster_policy_units (cluster_policy_id, policy_unit_id,
filter_sequence, factor) VALUES ('20d25257-b4bd-4589-92a6-c4c5c5d3fd1a',
'e659c871-0bf1-4ccc-b748-f28f5d08dffd', 0, 0);
Line 6: INSERT INTO cluster_policy_units (cluster_policy_id, policy_unit_id,
filter_sequence, factor) VALUES ('5a2b0939-7d46-4b73-a469-e9c2c7fc6a53',
'e659c871-0bf1-4ccc-b748-f28f5d08dffd', 0, 0);
Line 7: INSERT INTO cluster_policy_units (cluster_policy_id, policy_unit_id,
filter_sequence, factor) VALUES ('b4ed2332-a7ac-4d5f-9596-99a439cb2812',
'e659c871-0bf1-4ccc-b748-f28f5d08dffd', 0, 0);
--
To view, visit http://gerrit.ovirt.org/20018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24879ed64cab829969556fd71786b32d3aaaf0c7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
