Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: partial cleanup - db only ......................................................................
Patch Set 8: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/legacy/database.py Line 114: osetupcons.CoreEnv.UPGRADE_FROM_LEGACY Line 115: ], Line 116: ) Line 117: def _misc(self): Line 118: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Perhaps, not sure. Here it can be rolled back. If we fail during closeup before removing it, it will be left around. I think I prefer it this way. Line 119: filetransaction.FileTransaction( Line 120: name=( Line 121: osetupcons.FileLocations.LEGACY_PSQL_PASS_FILE Line 122: ), -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
