Omer Frenkel has posted comments on this change.
Change subject: engine: Create Gluster Volume & Volume Option Set
......................................................................
Patch Set 6: (1 inline comment)
looks good, just 1 minor comment, i will start verifying while you answer.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 669: VAR__TYPE__GLUSTER_VOLUME_OPTION=${type} Gluster Volume
if both VAR__TYPE__GLUSTER_VOLUME and VAR__TYPE__GLUSTER_VOLUME_OPTION return
the same value ("Gluster Volume") then the second is not needed..
--
To view, visit http://gerrit.ovirt.org/3142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5a857d188450409ce9f6eefd4df6bc1b10f9b2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
