Shireesh Anjal has posted comments on this change.
Change subject: engine: Create Gluster Volume & Volume Option Set
......................................................................
Patch Set 2: (11 inline comments)
Most comments incorporated. New patch-set to follow.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
Line 41: protected boolean canDoAction() {
Done
Line 44:
I think a derived class should not validate anything is the basic validations
from the base class fail. That's why I put this as the first check in the
method.
Line 48:
Done
Line 67:
Done
Line 73: if (volume.getVolumeType() == null) {
Done
Line 78: if (volume.getTransportType() == null) {
Done
Line 103:
Done
Line 202: private void addVolumeToDb(final GlusterVolumeEntity
createdVolume) {
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
Line 68: */
Done
Line 81: protected VdcReturnValueBase executeBllAction(VdcActionType
actionType, VdcActionParametersBase params) {
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeCommandBase.java
Line 17: private static final long serialVersionUID = -7394070330293300587L;
Done
--
To view, visit http://gerrit.ovirt.org/3142
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e5a857d188450409ce9f6eefd4df6bc1b10f9b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
