Shireesh Anjal has posted comments on this change.
Change subject: engine: DB scripts, entities and DAO for Gluster Volumes
......................................................................
Patch Set 3: (3 inline comments)
Responses to comments.
....................................................
File backend/manager/dbscripts/upgrade/03_01_0670_add_gluster_volume_tables.sql
Line 6: if (not exists (select 1 from INFORMATION_SCHEMA.TABLES where
table_name='gluster_volumes')) then
Thanks, I'll keep it as it is :)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeStatus.java
Line 18: public int getValue() {
Done
I'm going to store *all* my enums as varchar now.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
Line 760:
I love writing javadocs as well, but not when the method signature is so
obvious that it doesn't need one. In any case, I'll do it here to maintain
consistency with rest of the methods in the same source.
--
To view, visit http://gerrit.ovirt.org/2936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I820af17b8c9c7f0414f67bd03364ce3e14d6f178
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
