Yair Zaslavsky has posted comments on this change. Change subject: engine: DB scripts, entities and DAO for Gluster Volumes ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_0670_add_gluster_volume_tables.sql Line 6: if (not exists (select 1 from INFORMATION_SCHEMA.TABLES where table_name='gluster_volumes')) then Although we might have some mix in our upgrade scripts - currently we do not write them in a re-entrant way. In addition, common.sp includes utilities for performing what you did with Information schema. -- To view, visit http://gerrit.ovirt.org/2936 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820af17b8c9c7f0414f67bd03364ce3e14d6f178 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
