Yair Zaslavsky has posted comments on this change.
Change subject: engine: DB scripts, entities and DAO for Gluster Volumes
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeStatus.java
Line 18: public int getValue() {
Are you storing in DB the status as Int?
I would recommend storing this as varchar (more clear for debugging, for
example).
You can take a look at SnapshotStatus and its usage.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
Line 760:
Cam u add a comment here, same way jobDao has?
....................................................
File backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
Line 51:
GlusterVolumeDAO=org.ovirt.engine.core.dao.gluster.GlusterVolumeDAODbFacadeImpl
Althought the mixture , Please use the XXXDao convention and not XXXDAO - we
will revisit this for all DAOs.
....................................................
File config/engine-commit-template.txt
Line 1: engine: short summary under 50 chars (#xxxxxx)
Remove this from your patch.
--
To view, visit http://gerrit.ovirt.org/2936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I820af17b8c9c7f0414f67bd03364ce3e14d6f178
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
