Shireesh Anjal has posted comments on this change.
Change subject: engine: DB scripts, entities and DAO for Gluster Volumes
......................................................................
Patch Set 3: (7 inline comments)
Responses to inline comments.
....................................................
File backend/manager/dbscripts/gluster_volumes_sp.sql
Line 9:
Done
....................................................
File backend/manager/dbscripts/upgrade/03_01_0670_add_gluster_volume_tables.sql
Line 6: if (not exists (select 1 from INFORMATION_SCHEMA.TABLES where
table_name='gluster_volumes')) then
Currently all the *add*table*.sql scripts are doing this. Can you please let me
know which utility from common_sp.sql can be used for this purpose?
Alternatively name of any other upgrade script that correctly adds table(s)
would also be very helpful.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeStatus.java
Line 17:
Done
Line 18: public int getValue() {
I had used it by looking at some of the key existing tables like vds_dynamic.
Wouldn't mind changing it to varchar though. And I have multiple such enums.
Would you recommend storing all of them as varchar in DB?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
Line 760:
Done
Have done it, bud does it really add any value ?
....................................................
File backend/manager/modules/dal/src/main/jdbc-resources/engine-daos.properties
Line 51:
GlusterVolumeDAO=org.ovirt.engine.core.dao.gluster.GlusterVolumeDAODbFacadeImpl
Done
....................................................
File config/engine-commit-template.txt
Line 1: engine: short summary under 50 chars (#xxxxxx)
Done
--
To view, visit http://gerrit.ovirt.org/2936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I820af17b8c9c7f0414f67bd03364ce3e14d6f178
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
