Ofer Schreiber has posted comments on this change. Change subject: packaging: add controller class (plugins step 3/3) ......................................................................
Patch Set 6: Fails (2 inline comments) 1. Some inline comments 2. Please rebase 3. Please remove white-spaces .................................................... File packaging/fedora/setup/engine-setup.py Line 200 Need to reverse the DB upgrade order. .................................................... File packaging/fedora/setup/plugins/example_plugin_000.py Line 12: controller = Controller() The usage of controller is not clear, we should mention that it's a singleton. -- To view, visit http://gerrit.ovirt.org/1867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb95ecfb2e4a4a339137cb5de8495b3159101e65 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ronen Angluster <rangl...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Idan Mansano <imans...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
