Ofer Schreiber has posted comments on this change.
Change subject: packaging: add controller class (plugins step 3/3)
......................................................................
Patch Set 3: Fails
(6 inline comments)
1. inline comments
2. Please clean all un-needed whitespaces.
....................................................
File packaging/fedora/setup/engine-setup.py
Line 2113: controller.runAllSequences()
Why do we need this function?
Line 2242: def plugin_compare(x, y):
Any reason for this to be in setup and not utils?
Line 2260: match = re.search("^(.+\_\d\d\d)\.py$", item)
What are you searching for here?
this regexp should be explained
Line 2278: raise ImportError("Plugin %s does not contain the %s
function" % (plugin.__class__, funcName))
What will happen if I'll create a plugin without this function? engine-setup
will die?
....................................................
File packaging/fedora/setup/plugins/example_plugin_000.py
Line 4: """
Lets assume a simple plugin:
1. Adds new question ("What's your name?")
2. Adds a new sequence, appends you name to file X
how would the plugin writer implament this?
His function (which appends NAME to file X) needs to be able to access the
answer.
I can't understand from this how should he do that.
Line 70: "CONDITION" : False}
In order to add a simple question, should I add a new group as well?
the basic flow of adding a new "question" (param) is not so clear.
--
To view, visit http://gerrit.ovirt.org/1867
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb95ecfb2e4a4a339137cb5de8495b3159101e65
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ronen Angluster <rangl...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Idan Mansano <imans...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
