Ronen Angluster has posted comments on this change.
Change subject: packaging: add controller class (plugins step 3/3)
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 2113: controller.runAllSequences()
layer of abstraction. if in the future you might need to do some work around
the runAllSequences method.
and it looks cleaner.
Line 2242: def plugin_compare(x, y):
private use of a function for sorting purposes. its not a publicly used
function.
Line 2278: raise ImportError("Plugin %s does not contain the %s
function" % (plugin.__class__, funcName))
yes. thats why we check that the functions exist before doing anything else.
if a malformed plugin has been introduced, we raise an exception and exit.
--
To view, visit http://gerrit.ovirt.org/1867
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb95ecfb2e4a4a339137cb5de8495b3159101e65
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ronen Angluster <rangl...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Idan Mansano <imans...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
