Ofer Schreiber has posted comments on this change.
Change subject: packaging: add controller class (plugins step 3/3)
......................................................................
Patch Set 2: Fails; I would prefer that you didn't submit this
(2 inline comments)
1. running `make rpm` doesn't work.
....................................................
File Makefile
Line 153: cp -f ./packaging/fedora/setup/plugins/*
$(PREFIX)/usr/share/ovirt-engine/setup/plugins/
should be ovirt-engine/scripts
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 307: %attr (755,root,root) %{_datadir}/%{name}/scripts/plugins/*
No need for the *
just put %{_datadir}/%{name}/scripts/plugins and it will include all files.
--
To view, visit http://gerrit.ovirt.org/1867
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb95ecfb2e4a4a339137cb5de8495b3159101e65
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ronen Angluster <rangl...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Idan Mansano <imans...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ronen Angluster <rangl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
