Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add business entities
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
Line 20: public class Job extends IVdcQueryable implements BusinessEntity<Guid>
{
Validation aren't required here as those entities aren't update/provided by the
clients.
The job for example is being created prior to CommandBase.validateInputs().
The only field which is being sent is the correlationId which will have its own
treatment when implemented by adding it to VdcActionParameterBase.
Line 285: public void prettyPrint() {
i used for debug purpose to verify the traverse over the tree does the expected.
will remove it.
Line 287: System.out.println(String.format("%10s %20s %30s %30s %30s",
log has annoying prefix :-)
This will be be delete.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java
Line 263: public void prettyPrint(int i) {
Done
--
To view, visit http://gerrit.ovirt.org/1085
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc2351d2bb35cbad641f7ea0be93252602685ab0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
