Michael Kublin has posted comments on this change. Change subject: core: Add Task Manager business entities ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java Line 209: A little bit strange, actually a bean which contains a business logic including update of data base. Why not use for this JobRepository Line 222: The following three lines of code causes for three updates on DB. First of all it is not clear, but second you open a 2 transaction, but updates are related, as I understand they should be committed together. Line 251: same here, bean updated db -- To view, visit http://gerrit.ovirt.org/1085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2351d2bb35cbad641f7ea0be93252602685ab0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
