Livnat Peer has posted comments on this change. Change subject: core: Task Manager Add business entities ......................................................................
Patch Set 8: Looks good to me, but someone else must approve (5 inline comments) The patch looks good, all inline comments are optional. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/ExecutionStatus.java Line 5: */ How about using Job/Flow ExecutionStatus or other indicative class name. I think ExecutionStatus is too generic. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java Line 230: Date endJobTime = new Date(); why do we need the endJobTime local variable? .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java Line 37: Can the parent be job? If so the variable name is confusing. Line 82: I would encapsulate externalId and externalSystem as ExternalSystem BE with 2 properties, we might need to hold more data there in the future (maybe progress information?). Line 217: I am not sure I follow the logic here, can you please add documentation of the logic. -- To view, visit http://gerrit.ovirt.org/1085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc2351d2bb35cbad641f7ea0be93252602685ab0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
