Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Default Command Monitoring
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 219: try {
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java
Line 34: */
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 129:
JobRepositoryFactory.getJobRepository().updateStep(step);
correct about the condition.
As per logging, enabling logging for monitor objects might be relevant for
debug, since if the step doesn't exist, there is no documentation for it being
created nor deleted. Not sure there is such a use case for that.
Step are delete by deleting the Job in cascade; If the step was deleted, it
means the job does not exist. Also not a case for log.
Line 155:
it will be used for commands which aren't invoked not by the Backend or
RunMultipleActionRunner
--
To view, visit http://gerrit.ovirt.org/1089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0ee368f63ec5bdf54ef18072a45fe8f01acbde
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
