Michael Kublin has posted comments on this change.

Change subject: core: Add Task Manager Default Command Monitoring
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 213: 
General remark: in each command were added at least 6 new queries (update, 
insert), in current implementation it is also 6 new transactions. I think that 
we can force some performance degradation during tests over API (for example 
for 600 API calls). Hope that the degradation will be small.

--
To view, visit http://gerrit.ovirt.org/1089
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0ee368f63ec5bdf54ef18072a45fe8f01acbde
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to