Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Default Command Monitoring
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 53: job.setStartTime(new Date());
if i refer to job as a bean it is acceptable.
However, modified the step and job to be plan business entity.
Line 110:
monitoring is an attribute of the context.
it is used to determine how the command should be monitored.
even non monitored command could be monitored by default for their vdsm tasks.
Line 119: Job job = createJob(actionType, command);
Done
Line 261: if (context.shouldEndJob()) {
the ExecutionMethod.AsStep implies there is no job associated with the context,
instead a step is the entity held by the context.
For example, end job of VDSM task - the task holds only step id.
It has neither step or job, therefore the job should be fetched, set for
completed and updated.
--
To view, visit http://gerrit.ovirt.org/1089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0ee368f63ec5bdf54ef18072a45fe8f01acbde
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
