Moti Asayag has posted comments on this change.
Change subject: Preparation for query permissions - allow typing of queries as
admin/user queries and add runAsUser property to params
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java
Line 123: } finally {
it can null be if the following statement fails:
constructor = Class.forName(className).getDeclaredConstructor(Guid.class);
which might happens for various reasons.
however the finally block is not needed in case of exception is thrown.
the isAcessible won't be null if the constructor isn't null as its type is
primitive boolean.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
Line 140:
IMO it would be better to add a setter for both queryType and actionType, as in
any command/query invocation by the API we're using the actionType/QueryType
then by those getters we're doing the opposite.
Resolving the actionType/queryType for null values should remain, as the
command might be invoked not via the Backend.class apis.
--
To view, visit http://gerrit.ovirt.org/1243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83c3f85a9ad41638135c4c05a2660a27fda67a1e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
