> > > On Fri, 2005-01-14 at 16:34 +0100, Jerome Glisse wrote: > > > > > > > > Anyway i wanted to ask mesa folks how to make a real > > > > proper patch. The fact is that INREG & OUTREG in > > > > server/radeon_macros.h have to do endian swapping. > > > > Moreover the swapping is only needed for r300, isn't it ? > > > > So do we need to have our own copy of radeon_macros.h > > > > insted of using the one from dri/radeon/ ? > > > > > > No. Try this patch, which is quite ugly though, most of this shouldn't > > > be in driver specific code IMHO. > > > > > What about INREG16 & OUTREG ? > > The 3D driver shouldn't have write access to the registers, and at least > the radeon and r200 drivers only use 32 bit register reads because all > registers relevant to them are 32 bit. Has this changed in r300?
Don't think this have changed, i haven't looked to the whole code, still reading r200 & r300 code to understood the whole things :) > > I will try your patch but i bet it works. > > I am agree too that this should not be in driver specifique but how to > > handle the r300 case properly on ppc ? > > There's no 'r300 case'. This will be the same for all Radeons and > probably for most if not all other hardware as well. What i mean is that r200 already work on ppc and they never needed to have the endian swapping ? So if we have to endian swapping for all radeon maybe we could change radeon_macros.h and use the MESA_BIG_ENDIAN define ? In fact i was looking for the proper way to make this change the more acceptable & correct for mesa & dri. By the way i tested your patch and it works properly over here. > > By the way did you figure out a fix for endianness problem with 2d > > accel ? > > No worries, I never forget about mail. ;) I have an idea but haven't got > around to playing with it yet, hopefully on the weekend. I was more worrying that i lost a mail from you as i am moving my mailbox and already loose few of them :( Still another endian question, do you have any idea where i may look for properly send texture when i am on ppc. I have looked at r200 and it doesn't seems that there is any specifics things to do. But here with r300 we got the component switched :( Thx for your help. best, Jerome Glisse ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
