On Tue, 2005-01-18 at 14:22 +1100, Benjamin Herrenschmidt wrote: > On Fri, 2005-01-14 at 12:23 -0500, Michel DÃnzer wrote: > > On Fri, 2005-01-14 at 16:34 +0100, Jerome Glisse wrote: > > > > > > Anyway i wanted to ask mesa folks how to make a real > > > proper patch. The fact is that INREG & OUTREG in > > > server/radeon_macros.h have to do endian swapping. > > > Moreover the swapping is only needed for r300, isn't it ? > > > So do we need to have our own copy of radeon_macros.h > > > insted of using the one from dri/radeon/ ? > > > > No. Try this patch, which is quite ugly though, most of this shouldn't > > be in driver specific code IMHO. > > Gack ! You mean that the DRI doesn't use eieio for accessing MMIO > registers ? I have missed that. This is really bad. All 3 sizes, both > reads and writes, need to have eieio.
I know, but as I pointed out, the Radeon 3D drivers only use 32 bit reads. -- Earthling Michel DÃnzer | Debian (powerpc), X and DRI developer Libre software enthusiast | http://svcs.affero.net/rm.php?r=daenzer ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
