#34539: `get_prep_value` no longer called for JSONField
-------------------------------------+-------------------------------------
     Reporter:  Julie Rymer          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  4.2
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Natalia Bidart):

 As a Django user, I agree that the current documentation does imply that
 `get_prep_value()` would be called for any `Field` instance. I always
 assumed that everything documented for `Field` as a toplevel class applies
 to all children (except explicitly stated otherwise), so I can personally
 relate to the ticket description.

 Having said the above, if modifying the Django code could generate extra
 maintenance burden and/or introduce patterns that are not desired (such as
 including code that is not used by Django itself), I would at least
 suggest that the documentation is extended to explicitly say that
 `get_prep_value()` may not be called in every Django-provided field.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/34539#comment:16>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070187e7f08dd8-9fff13a8-3278-4e93-8eb3-ccbf5f9e4fc3-000000%40eu-central-1.amazonses.com.

Reply via email to