#34539: `get_prep_value` no longer called for JSONField
-------------------------------------+-------------------------------------
Reporter: Julie Rymer | Owner: (none)
Type: Bug | Status: new
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Julie Rymer):
Replying to [comment:20 Mariusz Felisiak]:
> Replying to [comment:19 Simon Charette]:
> > I never assumed that we guaranteed that `get_prep_lookup` would be
called by `get_db_prep_lookup` but I can see how it can be interpreted
this way from the docs.
> >
> > Given this was an unintended side-effect of
5c23d9f0c32f166c81ecb6f3f01d5077a6084318 I'd be +1 to having
`get_db_prep_value` start by calling `get_prep_value` when
`prepared=False`.
>
> OK, persuaded, let's restore it for `JSONField`.
>
> Julie, please prepare a patch (via GitHub PR) with a regression test and
release notes (`4.2.2.txt`.)
Cool, I'll try to do this this w-e :)
--
Ticket URL: <https://code.djangoproject.com/ticket/34539#comment:21>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070188068d5367-1f808881-23a3-4c36-a468-ad7052e0db03-000000%40eu-central-1.amazonses.com.
