#34539: `get_prep_value` no longer called for JSONField
-------------------------------------+-------------------------------------
Reporter: Julie Rymer | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Julie Rymer):
Replying to [comment:12 Mariusz Felisiak]:
> This is not true, removing `get_prep_value()` will not cause any tests
to fail, so it won't be tested.
You're right, but nothing a spy+`assert_called_once` can't solve :p
Also, I though I'd mention that I'd be willing to make the necessary
changes in case this scenario is selected (I'd not have that self-
confidence for a doc update however ^^)
Finally as a last input, I'll mention that the
[https://docs.djangoproject.com/en/4.2/howto/custom-model-fields/ custom
field doc] actually explicitly elaborate on some standard Field type
gotcha when they deviate from the Field API contract: `AutoField` and
`FileField`.
--
Ticket URL: <https://code.djangoproject.com/ticket/34539#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070187e7c9ac6e-36e43d60-08db-421f-b9b6-937cb2c8e2dd-000000%40eu-central-1.amazonses.com.
