#34539: `get_prep_value` no longer called for JSONField
-------------------------------------+-------------------------------------
Reporter: Julie Rymer | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: 4.2
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:9 Julie Rymer]:
> I think the question to solve is
> - do we want to add a warning that the documented rules for
customisation does not apply to some Field classes and to document the
missing rules, or
> - should we harmonize instead all Field classes that don't follow the
rules yet and make their behaviour consistent with current documentation.
> I am more in favour of the second option since it does seems to be less
of a change effort and more practical for the end-user.
This will required adding LOC (probably many) that are not used by Django
itself and aren't tested (unless we will add many tests with custom
subclasses of built-in fields). This can also cause a lot of backward
incompatible changes in the behavior. I'm strongly against it as it'll set
a dangerous precedent and increase the maintenance burden.
I'll wait for other opinions.
--
Ticket URL: <https://code.djangoproject.com/ticket/34539#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070187e6999877-9f6a8d84-f913-4f20-b885-10eeabe70b81-000000%40eu-central-1.amazonses.com.
