tqchen commented on code in PR #229: URL: https://github.com/apache/tvm-ffi/pull/229#discussion_r2508024927
########## include/tvm/ffi/function_details.h: ########## @@ -137,8 +145,11 @@ using FGetFuncSignature = std::string (*)(); /*! * \brief Auxilary argument value with context for error reporting */ +template <typename Type> Review Comment: Add Type to the doc `\tparam`, add comment on rationale why this is needed, because we need to support Type being template types such as `std::optional<T>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
