DarkSharpness commented on code in PR #229: URL: https://github.com/apache/tvm-ffi/pull/229#discussion_r2507353076
########## include/tvm/ffi/function_details.h: ########## @@ -134,11 +141,11 @@ struct FunctionInfo<R (Class::*)(Args...) const, /*! \brief Using static function to output typed function signature */ using FGetFuncSignature = std::string (*)(); -/*! - * \brief Auxilary argument value with context for error reporting - */ +template <typename Type, bool = TypeSupported<Type>> Review Comment: Yes, but it is not related to error message. The original `ArgValueWithContext` uses a template operator function, which may not be compatible with template constructor in some cases. You can see the example code [here](https://godbolt.org/z/KM5qzK5ME). For a template `ArgValueWithContext` with non-template operator function, this will no be a problem. A real-world example of this can be `std::optional`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
