DarkSharpness commented on code in PR #229: URL: https://github.com/apache/tvm-ffi/pull/229#discussion_r2507002294
########## include/tvm/ffi/function_details.h: ########## @@ -134,11 +141,11 @@ struct FunctionInfo<R (Class::*)(Args...) const, /*! \brief Using static function to output typed function signature */ using FGetFuncSignature = std::string (*)(); -/*! - * \brief Auxilary argument value with context for error reporting - */ +template <typename Type, bool = TypeSupported<Type>> Review Comment: This is mainly for a cleaner error message. For unsupported type, we will only have one compile error here: `error: static assertion failed: Argument type in FFI function signature can only be T, const T, or const T& or T&&`. If we fold `TypeSupported` into `ArgSupported`, this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
